Re: simplifying foreign key/RI checks

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: simplifying foreign key/RI checks
Date: 2022-03-14 08:33:26
Message-ID: CA+HiwqGGF=PNE6XhDcGriXGq6kEHnf7RZFRKSxeY7EGHCy=FhA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 18, 2022 at 3:30 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> v13 is attached.

I noticed that the recent 641f3dffcdf's changes to
get_constraint_index() made it basically unusable for this patch's
purposes.

Reading in the thread that led to 641f3dffcdf why
get_constraint_index() was changed the way it was, I invented in the
attached updated patch a get_fkey_constraint_index() that is local to
ri_triggers.c for use by the new ri_ReferencedKeyExists(), replacing
get_constraint_index() that no longer gives it the index it's looking
for.

--
Amit Langote
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v14-0001-Add-isolation-tests-for-snapshot-behavior-in-ri_.patch application/octet-stream 6.5 KB
v14-0002-Avoid-using-SPI-for-some-RI-checks.patch application/octet-stream 40.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-03-14 08:34:10 Re: BufferAlloc: don't take two simultaneous locks
Previous Message Kyotaro Horiguchi 2022-03-14 08:12:48 Re: BufferAlloc: don't take two simultaneous locks