Re: ExecRTCheckPerms() and many prunable partitions

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ExecRTCheckPerms() and many prunable partitions
Date: 2022-10-07 01:04:26
Message-ID: CA+HiwqGFCcapwkC4eYLJzaAQbonoYW4+JaVjxis+bhxTL6Aw=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 6, 2022 at 10:29 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> Actually, List of Bitmapsets turned out to be something that doesn't
> just-work with our Node infrastructure, which I found out thanks to
> -DWRITE_READ_PARSE_PLAN_TREES. So, I had to go ahead and add
> first-class support for copy/equal/write/read support for Bitmapsets,
> such that writeNode() can write appropriately labeled versions of them
> and nodeRead() can read them as Bitmapsets. That's done in 0003. I
> didn't actually go ahead and make *all* Bitmapsets in the plan trees
> to be Nodes, but maybe 0003 can be expanded to do that. We won't need
> to make gen_node_support.pl emit *_BITMAPSET_FIELD() blurbs then; can
> just use *_NODE_FIELD().

All meson builds on the cfbot machines seem to have failed, maybe
because I didn't update src/include/nodes/meson.build to add
'nodes/bitmapset.h' to the `node_support_input_i` collection. Here's
an updated version assuming that's the problem. (Will set up meson
builds on my machine to avoid this in the future.)

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v20-0001-Rework-query-relation-permission-checking.patch application/octet-stream 145.6 KB
v20-0003-Allow-adding-Bitmapsets-as-Nodes-into-plan-trees.patch application/octet-stream 5.0 KB
v20-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-ru.patch application/octet-stream 120.6 KB
v20-0004-Add-per-result-relation-extraUpdatedCols-to-Modi.patch application/octet-stream 27.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-10-07 01:08:36 Re: Issue with pg_stat_subscription_stats
Previous Message Виктория Шепард 2022-10-07 01:01:24 Re: Possible solution for masking chosen columns when using pg_dump