| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: CVE-2017-7484-induced bugs, or, btree cmp functions are not leakproof? |
| Date: | 2019-09-05 09:56:29 |
| Message-ID: | CA+HiwqG9HqH+ZYGNLN47jXmLxUoJE9bquYG_VsW98gLveF+AmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 5, 2019 at 6:33 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> /*
> + * For inheritance child relations, we also need to remember
> + * the root parent.
> + */
> + if (parent->rtekind == RTE_RELATION)
> + rel->inh_root_relid = parent->inh_root_relid > 0 ?
> + parent->inh_root_relid :
> + parent->relid;
> + else
> + /* Child relation of flattened UNION ALL subquery. */
> + rel->inh_root_relid = relid;
>
> With the current changes, parent->inh_root_relid will always be > 0 so
> (parent->inh_root_relid > 0) condition doesn't make sence. Right?
Oops, you're right. It should be:
if (parent->rtekind == RTE_RELATION)
rel->inh_root_relid = parent->inh_root_relid;
else
rel->inh_root_relid = relid;
Updated patch attached.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Use-root-parent-s-permissions-when-reading-child-.patch | application/octet-stream | 10.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2019-09-05 10:17:36 | Re: CVE-2017-7484-induced bugs, or, btree cmp functions are not leakproof? |
| Previous Message | Esteban Zimanyi | 2019-09-05 09:39:44 | Specifying attribute slot for storing/reading statistics |