Re: Eliminating SPI from RI triggers - take 2

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Jacob Champion <jchampion(at)timescale(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Eliminating SPI from RI triggers - take 2
Date: 2022-07-06 02:55:26
Message-ID: CA+HiwqFLpUCQ4CA1U-zpxpcUVjkuN7PenU-QMiZ0u-SHk9eRqQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 6, 2022 at 3:24 AM Jacob Champion <jchampion(at)timescale(dot)com> wrote:
> On Thu, Jun 30, 2022 at 11:23 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> >
> > I will continue investigating what to do about points (1) and (2)
> > mentioned above and see if we can do away with using SQL in the
> > remaining cases.
>
> Hi Amit, looks like isolation tests are failing in cfbot:
>
> https://cirrus-ci.com/task/6642884727275520
>
> Note also the uninitialized variable warning that cfbot picked up;
> that may or may not be related.

Thanks for the heads up.

Yeah, I noticed the warning when I compiled with a different set of
gcc parameters, though not the isolation test failures, so not sure
what the bot is running into.

Attaching updated patches which fix the warning and a few other issues
I noticed.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v2-0002-Avoid-using-an-SQL-query-for-some-RI-checks.patch application/octet-stream 37.4 KB
v2-0001-Avoid-using-SPI-in-RI-trigger-functions.patch application/octet-stream 33.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2022-07-06 03:25:42 Re: ExecRTCheckPerms() and many prunable partitions
Previous Message osumi.takamichi@fujitsu.com 2022-07-06 02:48:07 RE: Re-order "disable_on_error" in tab-complete COMPLETE_WITH