| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, jian he <jian(dot)universality(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remaining sql/json patches |
| Date: | 2023-12-07 12:07:59 |
| Message-ID: | CA+HiwqFKhM=6fN3Np61uYGCsOGdBKk1K1MbCQ0Q6LMNWGShQ0A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 7, 2023 at 7:51 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> On 2023-Dec-07, Erik Rijkers wrote:
>
> > Hm, this set doesn't apply for me. 0003 gives error, see below (sorrty for
> > my interspersed bash echoing - seemed best to leave it in.
> > (I'm using patch; should be all right, no? Am I doing it wrong?)
>
> There's definitely something wrong with the patch file; that binary file
> should not be there. OTOH clearly if we ever start including binary
> files in our tree, `patch` is no longer going to cut it. Maybe we won't
> ever do that, though.
>
> There's also a complaint about whitespace.
Looks like I messed something up when using git (rebase -i). :-(
Apply-able patches attached, including fixes based on jian he's comments.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v30-0002-Add-soft-error-handling-to-populate_record_field.patch | application/octet-stream | 24.0 KB |
| v30-0001-Add-soft-error-handling-to-some-expression-nodes.patch | application/octet-stream | 9.5 KB |
| v30-0005-JSON_TABLE-don-t-assign-precedence-to-NESTED-PAT.patch | application/octet-stream | 4.7 KB |
| v30-0004-JSON_TABLE.patch | application/octet-stream | 176.2 KB |
| v30-0003-SQL-JSON-query-functions.patch | application/octet-stream | 195.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2023-12-07 12:09:07 | Re: Reducing output size of nodeToString |
| Previous Message | Bharath Rupireddy | 2023-12-07 11:59:55 | Re: Is WAL_DEBUG related code still relevant today? |