| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remaining sql/json patches |
| Date: | 2024-03-20 12:53:52 |
| Message-ID: | CA+HiwqFAfKnHnwe0UeeDr4NeUupKV+sfwXp9YoxVWYSTPDZkGg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 20, 2024 at 8:46 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> looking at documentation again.
> one very minor question (issue)
>
> + <para>
> + The <literal>ON EMPTY</literal> clause specifies the behavior if the
> + <replaceable>path_expression</replaceable> yields no value at all; the
> + default when <literal>ON EMPTY</literal> is not specified is to return
> + a null value.
> + </para>
>
> I think it should be:
>
> applying <replaceable>path_expression</replaceable>
> or
> evaluating <replaceable>path_expression</replaceable>
>
> not "the <replaceable>path_expression</replaceable>"
> ?
Thanks. Fixed this, the other issues you mentioned, a bunch of typos
and obsolete comments, etc.
I'll push 0001 tomorrow.
--
Thanks, Amit Langote
| Attachment | Content-Type | Size |
|---|---|---|
| v44-0001-Add-SQL-JSON-query-functions.patch | application/octet-stream | 192.5 KB |
| v44-0002-JSON_TABLE.patch | application/octet-stream | 190.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2024-03-20 13:00:00 | Test 031_recovery_conflict.pl is not immune to autovacuum |
| Previous Message | Matthias van de Meent | 2024-03-20 12:03:39 | Re: Reducing output size of nodeToString |