From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: partition routing layering in nodeModifyTable.c |
Date: | 2020-10-20 02:28:26 |
Message-ID: | CA+HiwqF31pQa+D4iX6B_tCJfohnuzBT5Ub7+-D2bNiqHE9R1rw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Oct 19, 2020 at 8:48 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> On 19/10/2020 07:54, Amit Langote wrote:
> > On Sun, Oct 18, 2020 at 12:54 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >> Well, I was thinking on making the ri_PartitionInfo be about
> >> partitioning in general, not just specifically for partition tuple
> >> routing. Maybe Heikki is right that it may end up being simpler to
> >> remove ri_PartitionInfo altogether. It'd just be a couple of additional
> >> pointers in ResultRelInfo after all.
> >
> > So that's 2 votes for removing PartitionRoutingInfo from the tree.
> > Okay, I have tried that in the attached 0002 patch. Also, I fixed
> > some comments in 0001 that still referenced PartitionToRootMap.
>
> Pushed, with minor comment changes.
Thank you.
> I also noticed that the way the getTargetResultRelInfo() helper function
> was used, was a bit messy. It was used when firing AFTER STATEMENT
> triggers, but for some reason the code to fire BEFORE STATEMENT triggers
> didn't use it but duplicated the logic instead. I made that a bit
> simpler, by always setting the rootResultRelInfo field in
> ExecInitModifyTable(), making the getTargetResultRelInfo() function
> unnecessary.
Good, I was mildly annoyed by that function too.
--
Amit Langote
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | tsunakawa.takay@fujitsu.com | 2020-10-20 02:30:57 | RE: [POC] Fast COPY FROM command for the table with foreign partitions |
Previous Message | Andres Freund | 2020-10-20 02:05:14 | Re: Reduce the dependence on access/xlog_internal.h |