Re: ExecRTCheckPerms() and many prunable partitions

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ExecRTCheckPerms() and many prunable partitions
Date: 2022-11-07 07:03:45
Message-ID: CA+HiwqEYCLRZ2Boq_uK0pjLn_9b8XL-LmwKj7HN5kJOivUkYLg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 4, 2022 at 8:46 AM Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> 2022年10月15日(土) 15:01 Amit Langote <amitlangote09(at)gmail(dot)com>:
> > On Fri, Oct 7, 2022 at 4:31 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > On Fri, Oct 7, 2022 at 3:49 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > > On Fri, Oct 7, 2022 at 1:25 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > > > On Fri, Oct 7, 2022 at 10:04 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > > > > On Thu, Oct 6, 2022 at 10:29 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > > > > > Actually, List of Bitmapsets turned out to be something that doesn't
> > > > > > > just-work with our Node infrastructure, which I found out thanks to
> > > > > > > -DWRITE_READ_PARSE_PLAN_TREES. So, I had to go ahead and add
> > > > > > > first-class support for copy/equal/write/read support for Bitmapsets,
> > > > > > > such that writeNode() can write appropriately labeled versions of them
> > > > > > > and nodeRead() can read them as Bitmapsets. That's done in 0003. I
> > > > > > > didn't actually go ahead and make *all* Bitmapsets in the plan trees
> > > > > > > to be Nodes, but maybe 0003 can be expanded to do that. We won't need
> > > > > > > to make gen_node_support.pl emit *_BITMAPSET_FIELD() blurbs then; can
> > > > > > > just use *_NODE_FIELD().
> > > > > >
> > > > > > All meson builds on the cfbot machines seem to have failed, maybe
> > > > > > because I didn't update src/include/nodes/meson.build to add
> > > > > > 'nodes/bitmapset.h' to the `node_support_input_i` collection. Here's
> > > > > > an updated version assuming that's the problem. (Will set up meson
> > > > > > builds on my machine to avoid this in the future.)
> > > > >
> > > > > And... noticed that a postgres_fdw test failed, because
> > > > > _readBitmapset() not having been changed to set NodeTag would
> > > > > "corrupt" any Bitmapsets that were created with it set.
> > > >
> > > > Broke the other cases while fixing the above. Attaching a new version
> > > > again. In the latest version, I'm setting Bitmapset.type by hand with
> > > > an XXX comment nearby saying that it would be nice to change that to
> > > > makeNode(Bitmapset), which I know sounds pretty ad-hoc.
> > >
> > > Sorry, I attached the wrong patches with the last email. The
> > > "correct" v22 attached this time.
> >
> > Rebased over c037471832.
>
> This entry was marked as "Needs review" in the CommitFest app but cfbot
> reports the patch no longer applies.
>
> We've marked it as "Waiting on Author". As CommitFest 2022-11 is
> currently underway, this would be an excellent time update the patch.

Thanks for the heads up.

> Once you think the patchset is ready for review again, you (or any
> interested party) can move the patch entry forward by visiting
>
> https://commitfest.postgresql.org/40/3224/
>
> and changing the status to "Needs review".

Rebased patch attached and done.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v24-0003-Allow-adding-Bitmapsets-as-Nodes-into-plan-trees.patch application/octet-stream 5.5 KB
v24-0002-Do-not-add-hidden-OLD-NEW-RTEs-to-stored-view-ru.patch application/octet-stream 121.0 KB
v24-0004-Add-per-result-relation-extraUpdatedCols-to-Modi.patch application/octet-stream 26.1 KB
v24-0001-Rework-query-relation-permission-checking.patch application/octet-stream 145.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2022-11-07 07:43:00 Re: New docs chapter on Transaction Management and related changes
Previous Message Michael Paquier 2022-11-07 06:58:13 Re: [PATCH] Add native windows on arm64 support