| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Thom Brown <thom(at)linux(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, David Rowley <dgrowleyml(at)gmail(dot)com>, Jacob Champion <jchampion(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: generic plans and "initial" pruning |
| Date: | 2023-08-03 08:37:39 |
| Message-ID: | CA+HiwqE=qxN5C-oN5vguBZOZGyDRAMV2EW1pO_hObcpf6X5QwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 2, 2023 at 10:39 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> Having extracted the ExecEndNode() change, I'm also starting to feel
> inclined to extract a couple of other bits from the main patch as
> separate patches, such as moving the ExecutorStart() call from
> PortalRun() to PortalStart() for the multi-query portals. I'll do
> that in the next version.
Here's a patch set where the refactoring to move the ExecutorStart()
calls to be closer to GetCachedPlan() (for the call sites that use a
CachedPlan) is extracted into a separate patch, 0002. Its commit
message notes an aspect of this refactoring that I feel a bit nervous
about -- needing to also move the CommandCounterIncrement() call from
the loop in PortalRunMulti() to PortalStart() which now does
ExecutorStart() for the PORTAL_MULTI_QUERY case.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v44-0004-Set-inFromCl-to-false-in-child-table-RTEs.patch | application/octet-stream | 3.7 KB |
| v44-0006-Track-opened-range-table-relations-in-a-List-in-.patch | application/octet-stream | 2.4 KB |
| v44-0002-Refactoring-to-move-ExecutorStart-calls-to-be-ne.patch | application/octet-stream | 25.8 KB |
| v44-0003-Add-field-to-store-parent-relids-to-Append-Merge.patch | application/octet-stream | 21.2 KB |
| v44-0005-Delay-locking-of-child-tables-in-cached-plans-un.patch | application/octet-stream | 101.6 KB |
| v44-0001-Make-PlanState-tree-cleanup-non-recursive.patch | application/octet-stream | 28.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2023-08-03 08:50:52 | Re: Adding a LogicalRepWorker type field |
| Previous Message | Laetitia Avrot | 2023-08-03 08:36:50 | Adding a pg_servername() function |