| From: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, Sergei Agalakov <sergei(dot)agalakov(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: explain plans with information about (modified) gucs |
| Date: | 2019-03-18 10:31:48 |
| Message-ID: | CA+FpmFeBVwVyAxyMd9MX1jD8fUA3Qg96Po6sV+Po57egySKpGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 24 Feb 2019 at 00:06, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>
> Hi,
>
> attached is an updated patch, fixing and slightly tweaking the docs.
>
>
> Barring objections, I'll get this committed later next week.
>
I was having a look at this patch, and this kept me wondering,
+static void
+ExplainShowSettings(ExplainState *es)
+{
Is there some reason for not providing any explanation above this
function just like the rest of the functions in this file?
Similarly, for
struct config_generic **
get_explain_guc_options(int *num)
{
/* also bail out of there are no options */
+ if (!num)
+ return;
I think you meant 'if' instead if 'of' here.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rafia Sabih | 2019-03-18 11:42:23 | Re: [HACKERS] CLUSTER command progress monitor |
| Previous Message | Peter Eisentraut | 2019-03-18 10:22:40 | Re: chained transactions |