Re: Replication slot xmin is not reset if HS feedback is turned off while standby is shut down

From: Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: Replication slot xmin is not reset if HS feedback is turned off while standby is shut down
Date: 2017-01-13 10:17:44
Message-ID: CA+CSw_vQb+F9+wGKo=ZLK4QHZxt09FfT8KAFD6y_1cHH7wrC9Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5 Jan 2017 2:54 a.m., "Craig Ringer" <craig(at)2ndquadrant(dot)com> wrote:
> Ants, do you think you'll have a chance to convert your shell script
> test into a TAP test in src/test/recovery?
>
> Simon has said he would like to commit this fix. I'd personally be
> happier if it had a test to go with it.
>
> You could probably just add to src/test/recover/t/001 which now
> contains my additions for hot standby.

Do you feel the test in the attached patch is enough or would you like
to see anything else covered?

Regards,
Ants Aasma

Attachment Content-Type Size
send-hot-standby-feedback-on-first-connect-v4.patch text/x-patch 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rafia Sabih 2017-01-13 10:55:40 Re: Passing query string to workers
Previous Message Wolfgang Wilhelm 2017-01-13 10:09:40 Re: Packages: Again