Re: BUG #15977: Inconsistent behavior in chained transactions

From: fn ln <emuser20140816(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15977: Inconsistent behavior in chained transactions
Date: 2019-09-07 09:58:20
Message-ID: CA+99BHqSVBpJZ9pD=QczBs5L8KfuAvi3rYkKRbXXNE0cADoB+A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

> Looking at the latest patch, the comment blocks on top of TBLOCK_STARTED
> and TBLOCK_IMPLICIT_INPROGRESS in EndTransactionBlock() need an update
> to mention the difference of behavior with chained transactions. And
> the same comment rework should be done in UserAbortTransactionBlock()
> for TBLOCK_IMPLICIT_INPROGRESS/TBLOCK_STARTED?
I made another patch for that.
I don't have much confidence with my English spelling so further
improvements may be needed.

> If it is too much a change and potential regression, then I think that the
> "and chain" variants should be consistent and just raise warnings.
We don't have an exact answer for implicit transaction chaining behavior
yet.
So I think it's better to disable this feature until someone discovers the
use cases for this.
Permitting AND CHAIN without a detailed specification might cause troubles
in future.

Attachment Content-Type Size
disable-implicit-transaction-chaining-v5.patch application/octet-stream 5.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2019-09-07 10:16:51 Re: BUG #15977: Inconsistent behavior in chained transactions
Previous Message Fabien COELHO 2019-09-07 06:54:42 Re: BUG #15977: Inconsistent behavior in chained transactions

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-09-07 10:16:51 Re: BUG #15977: Inconsistent behavior in chained transactions
Previous Message Fabien COELHO 2019-09-07 06:54:42 Re: BUG #15977: Inconsistent behavior in chained transactions