Re: pgsql: Refactor libpq state machine for negotiating encryption

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor libpq state machine for negotiating encryption
Date: 2024-04-10 23:18:31
Message-ID: CA+hUKG+HRTtB+x+KKKj_cfX6sNhbeGuqmGxjGMwdVPG7YGFP8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Apr 8, 2024 at 1:25 PM Heikki Linnakangas
<heikki(dot)linnakangas(at)iki(dot)fi> wrote:
> Refactor libpq state machine for negotiating encryption
>
> This fixes the few corner cases noted in commit 705843d294, as shown
> by the changes in the test.
>
> Author: Heikki Linnakangas, Matthias van de Meent
> Reviewed-by: Jacob Champion

If -Dssl=none and -Dgssapi=disabled, compilation of fe-connect.c
fails: call to undeclared function 'encryption_negotiation_failed'. I
didn't look too hard, but maybe ENABLE_GSS and USE_GSS are confused?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-04-10 23:25:42 Re: pgsql: Refactor libpq state machine for negotiating encryption
Previous Message Tom Lane 2024-04-10 19:46:16 pgsql: Fix plpgsql's handling of -- comments following expressions.