Re: [HACKERS] [PATCH] Generic type subscripting

From: "Dian M Fay" <dian(dot)m(dot)fay(at)gmail(dot)com>
To: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>, "Dmitry Dolgov" <9erthalion6(at)gmail(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andres Freund" <andres(at)anarazel(dot)de>, "Alexander Korotkov" <aekorotkov(at)gmail(dot)com>, "Justin Pryzby" <pryzby(at)telsasoft(dot)com>, "David Steele" <david(at)pgmasters(dot)net>, "Nikita Glukhov" <n(dot)gluhov(at)postgrespro(dot)ru>, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com>, "David Fetter" <david(at)fetter(dot)org>, "Thomas Munro" <thomas(dot)munro(at)gmail(dot)com>, "Oleksandr Shulgin" <oleksandr(dot)shulgin(at)zalando(dot)de>, "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com>, "Oleg Bartunov" <obartunov(at)gmail(dot)com>, "Peter Eisentraut" <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Date: 2021-01-20 14:58:43
Message-ID: C8O2OLT387R2.1RSB78Z4ZZ335@lamia
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue Jan 19, 2021 at 1:42 PM EST, Pavel Stehule wrote:
> Hi
> I found minor issues.
> Doc - missing tag
> and three whitespaces issues
> see attached patch
> Following sentence is hard to read due long nested example
> If the
> + path contradicts structure of modified <type>jsonb</type> for any
> individual
> + value (e.g. path <literal>val['a']['b']['c']</literal> assumes keys
> + <literal>'a'</literal> and <literal>'b'</literal> have object values
> + assigned to them, but if <literal>val['a']</literal> or
> + <literal>val['b']</literal> is null, a string, or a number, then the
> path
> + contradicts with the existing structure), an error is raised even if
> other
> + values do conform.
> It can be divided into two sentences - predicate, and example.
> Regards
> Pavel

Here's a full editing pass on the documentation, with v45 and Pavel's
doc-whitespaces-fix.patch applied. I also corrected a typo in one of the
added hints.

Attachment Content-Type Size
0001-Revise-jsonb-subscripting-documentation.patch text/plain 9.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-01-20 15:28:44 Re: Wrong usage of RelationNeedsWAL
Previous Message Simon Riggs 2021-01-20 14:58:39 Re: Discarding DISCARD ALL