Re: [bug fix] pg_ctl always uses the same event source

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Robert Haas" <robertmhaas(at)gmail(dot)com>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_ctl always uses the same event source
Date: 2014-05-08 11:17:46
Message-ID: C8293F3BCF00430E978A8C36462CF71A@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

From: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
Only one minor suggestion:
+ Name of the event source for pg_ctl to use for event log. The
+ default is PostgreSQL.

From this description, it is not clear when the event log will be used
in pg_ctl. For example, if user uses -e option with register, then he
might expect any failure during register command will be logged into
eventlog, but that is not true. So I think we should improve the docs
to reflect the usage of -e.

On Linux, I am getting below build failure for pg_ctl

pg_ctl.c: In function ‘main’:
pg_ctl.c:2173: error: ‘event_source’ undeclared (first use in this
pg_ctl.c:2173: error: (Each undeclared identifier is reported only once
pg_ctl.c:2173: error: for each function it appears in.)
make[3]: *** [pg_ctl.o] Error 1
make[2]: *** [all-pg_ctl-recurse] Error 2
make[1]: *** [all-bin-recurse] Error 2
make: *** [all-src-recurse] Error 2

Thank you for reviewing and testing. I changed the doc, but I'd appreciate
it if you could improve my poor English and update the CommitFest if it can
be better.

I rebased the patch to HEAD and removed the compilation error on Linux. I
made event_source variable on all platforms like register_servicename,
although they are not necessary on non-Windows platforms.


Attachment Content-Type Size
pg_ctl_eventsrc_v9.patch application/octet-stream 9.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-05-08 11:56:46 Re: PGDLLEXPORTing all GUCs?
Previous Message Simon Riggs 2014-05-08 11:02:52 Re: [v9.5] Custom Plan API