| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dong Wook Lee <sh95119(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: old_snapshot: add test for coverage |
| Date: | 2022-11-17 12:41:49 |
| Message-ID: | C3CB0C0A-3B59-488E-8B8D-8A158990AC9D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 8 Aug 2022, at 07:37, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Dong Wook Lee <sh95119(at)gmail(dot)com> writes:
>> I wrote a test of the old_snapshot extension for coverage.
>
> Hmm, does this really provide any meaningful coverage? The test
> sure looks like it's not doing much.
Looking at this I agree, this test doesn't provide enough to be of value and
the LIMIT 0 might even hide bugs under a postive test result. I think we
should mark this entry RwF.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-11-17 12:51:41 | Introduce a new view for checkpointer related stats |
| Previous Message | Spyridon Dimitrios Agathos | 2022-11-17 12:23:27 | CREATE UNLOGGED TABLE seq faults when debug_discard_caches=1 |