Re: Proposed patch for error locations

On Mar 13, 2006, at 2:37 , Tom Lane wrote:

> to wit, that we make use of bison's "locations" feature to track token
> positions in the grammar, and add locations to raw parse tree nodes as
> needed.
>
> Some examples of what it can do:

This looks really nice.

> One thing I'm noticing already is that the addition of "at
> character N"
> to a lot of these messages isn't an improvement. In psql it's
> certainly
> redundant with the error-cursor display.

The pure character count is definitely difficult to use with larger
queries. I think it could be more useful if it were
line:char_of_line. Would others find this useful?

Michael Glaesemann
grzm myrealbox com