|From:||Steve Singer <steve(at)ssinger(dot)info>|
|To:||Andres Freund <andres(at)2ndquadrant(dot)com>|
|Subject:||Re: [PATCH 09/14] Adjust all *Satisfies routines to take a HeapTuple instead of a HeapTupleHeader|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 12-11-14 08:17 PM, Andres Freund wrote:
> For the regular satisfies routines this is needed in prepareation of logical
> decoding. I changed the non-regular ones for consistency as well.
> The naming between htup, tuple and similar is rather confused, I could not find
> any consistent naming anywhere.
> This is preparatory work for the logical decoding feature which needs to be
> able to get to a valid relfilenode from when checking the visibility of a
I have taken a look at this patch. The patch does what it says, it
changes a bunch of
HeapTupleSatisfiesXXXX routines to take a HeapTuple structure instead of
It also sets the HeapTuple.t_tableOid value before calling these routines.
The patch does not modify these routines to actually do anything useful
with the additional data fields though it does add some assertions to
make sure t_tableOid is set.
The patch compiles cleanly and the unit tests pass.
This patch does not seem to depend on any of the other patches in this
set and applies cleanly against master. The patch doesn't actually add
any functionality, unless someone sees a reason for complaining about
this that I don't see, then I think it can be committed.
> contrib/pgrowlocks/pgrowlocks.c | 2 +-
> src/backend/access/heap/heapam.c | 13 ++++++----
> src/backend/access/heap/pruneheap.c | 16 ++++++++++--
> src/backend/catalog/index.c | 2 +-
> src/backend/commands/analyze.c | 3 ++-
> src/backend/commands/cluster.c | 2 +-
> src/backend/commands/vacuumlazy.c | 3 ++-
> src/backend/storage/lmgr/predicate.c | 2 +-
> src/backend/utils/time/tqual.c | 50 +++++++++++++++++++++++++++++-------
> src/include/utils/snapshot.h | 4 +--
> src/include/utils/tqual.h | 20 +++++++--------
> 11 files changed, 83 insertions(+), 34 deletions(-)
|Next Message||Peter Eisentraut||2012-11-17 06:16:06||Re: Doc patch, put RAISE USING keywords into a table|
|Previous Message||Noah Misch||2012-11-17 03:31:51||Re: foreign key locks|