| From: | Roma Sokolov <sokolov(dot)r(dot)v(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)timbira(dot)com(dot)br> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Женя Зайцев <zevlg(at)yandex(dot)ru> |
| Subject: | Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator |
| Date: | 2016-03-01 16:08:46 |
| Message-ID: | BF79B347-E974-4FF8-843D-9FBD68596F35@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Feb 2016, at 03:46, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:
> Because it is not a common practice to test catalog dependency on
> separate tests (AFAICS initial catalogs are tested with oidjoins.sql).
> Also, your test case is too huge for such a small use case.
It seems oidjoins.sql is automatically generated and contains tests only for
initial database state. On the other hand, there are tests for CREATE OPERATOR
and ALTER OPERATOR, so it seems reasonable to me to have separate DROP OPERATOR
test, or to move all operator related testing to one file. This is however
clearly outside of the scope of this patch, so in v3 I've simplified tests using
queries from oidjoins.sql.
Cheers,
Roma
| Attachment | Content-Type | Size |
|---|---|---|
| fix_drop_operator_reset_oprcom_and_oprnegate_fields_v3.patch | application/octet-stream | 12.2 KB |
| unknown_filename | text/plain | 2 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2016-03-01 16:16:23 | Re: pg_dump dump catalog ACLs |
| Previous Message | Atri Sharma | 2016-03-01 16:05:54 | Re: PROPOSAL: Fast temporary tables |