| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Avoid assuming there will be only 3 states for synchronous_commi |
| Date: | 2011-04-04 23:10:42 |
| Message-ID: | BANLkTimq-YBiBQGZ5Ok5nKurJWSnDYiAXA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Apr 4, 2011 at 6:24 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Avoid assuming there will be only 3 states for synchronous_commit.
> Also avoid hardcoding the current default state by giving it the name
> "on" and replace with a meaningful name that reflects its behaviour.
> Coding only, no change in behaviour.
I think changing the test to > SYNCHRONOUS_COMMIT_OFF is an
improvement, but I don't particularly like the renaming portion of
this change - now the internal names don't match what the user types,
which seems less clear, and inconsistent with every other enum-type
GUC.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shigeru HANADA | 2011-04-05 04:37:48 | Re: Re: [COMMITTERS] pgsql: Support comments on FOREIGN DATA WRAPPER and SERVER objects. |
| Previous Message | Simon Riggs | 2011-04-04 22:24:15 | pgsql: Avoid assuming there will be only 3 states for synchronous_commi |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dan Ports | 2011-04-04 23:46:08 | Re: time table for beta1 |
| Previous Message | Robert Haas | 2011-04-04 23:04:59 | Re: time table for beta1 |