Re: BUG #5856: pg_attribute.attinhcount is not correct.

On Fri, Apr 1, 2011 at 12:56 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Thu, Mar 31, 2011 at 11:11:49AM -0400, Robert Haas wrote:
>> On Thu, Mar 31, 2011 at 6:06 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>> >> I think this is a manifestation the same problem mentioned here:
>> >>
>> >> http://git.postgresql.org/gitweb?p=postgresql.git;a=commit;h=31b6fc06d83c6de3644c8f2921eb7de0eb92fac3
>> >>
>> >> I believe this requires some refactoring to fix. ?It would be good to do that.
>> >
>> > The best way I can see is to make ATExecAddColumn more like ATExecDropColumn,
>> > ATAddCheckConstraint, and ATExecDropConstraint. ?Namely, recurse at Exec-time
>> > rather than Prep-time, and cease recursing when we satisfy the ADD COLUMN with a
>> > merge. ?Did you have something else in mind?
>>
>> I had exactly what you just said in mind.
>
> Patch attached, then.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company