On Wed, May 4, 2011 at 21:09, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On ons, 2011-05-04 at 20:32 +0200, Magnus Hagander wrote:
>> Is this part really correct?
>> - fprintf(stderr, _("%s: final receive failed: %s\n"),
>> + fprintf(stderr, _("%s: final receive failed: %s"),
>> all other msgs have \n.. I see you removed the final dot in many of
>> the other messages, did you just accidentally grab one too many?
>> (There are a couple of other examples of removing the \n though, so
>> perhaps it was intentional? But they're all preceeding
>> disconnect_and_exit() so I don't see why it shouldn't be consistent?
> The result of PQerrorMessage() already ends in \n.
> With that in mind, maybe I missed something?
Oh, d'uh. I'm not paying attention. Sorry about the noise.
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2011-05-04 19:41:46|
|Subject: Re: Prefered Types|
|Previous:||From: Kevin Grittner||Date: 2011-05-04 19:15:15|
|Subject: Re: 'SGT DETAIL: Could not open file "pg_clog/05DC": No such file or directory' - what to do now?|
pgsql-committers by date
|Next:||From: Bruce Momjian||Date: 2011-05-05 16:49:25|
|Subject: pgsql: Improve style of generate_history.pl Perl script.|
|Previous:||From: Peter Eisentraut||Date: 2011-05-04 19:09:54|
|Subject: Re: [COMMITTERS] pgsql: Message style cleanup|