pgadmin III - "Display objects" part of database restore errors out in non-English locales

From: Nikhil S <nixmisc(at)gmail(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: pgadmin III - "Display objects" part of database restore errors out in non-English locales
Date: 2011-05-18 11:58:40
Message-ID: BANLkTikYccZ85zr_=FygFkiysg00G3QqBA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

So, I changed the locale on my setup to "zh_CN.UTF-8" and tried to restore
into a database using a backup from earlier. When I click on "Display
objects" tab, I see an error being displayed, although the actual restore
happens just fine. Note that no error occurs in English locales.

Took me a while to figure this one out. The issue is with
frmRestore::OnEndProcess() function. It naively avoids lines containing ";"
or "P" as the first letter. So in the English locale, the last line about
the "Process returned exit code 0" is handled. However in other locales,
this will be translated and hence the last line will be inspected leading to
a spurious error.

The fix is to avoid inspecting the last line. The attached patch does that.

Regards,
Nikhils

Attachment Content-Type Size
pgadmin3_issue_with_display_objects_restore.patch application/x-download 1018 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil S 2011-05-18 12:03:28 Re: pgadmin III - "Display objects" part of database restore errors out in non-English locales
Previous Message pgAdmin Trac 2011-05-17 19:50:20 [pgAdmin III] #318: Window sizing