|From:||Daniel Gustafsson <daniel(at)yesql(dot)se>|
|To:||PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||TLS checking in pgstat|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
As I mentioned in , checking (struct Port)->ssl for NULL to determine
whether TLS is used for connection is a bit of a leaky abstraction, as that's
an OpenSSL specific struct member. This sets the requirement that all TLS
implementations use a pointer named SSL, and that the pointer is set to NULL in
case of a failed connection, which may or may not fit.
Is there a reason to not use (struct Port)->ssl_in_use flag which tracks just
what we're looking for here? This also maps against other parts of the
abstraction in be-secure.c which do just that. The attached implements this.
|Next Message||Dilip Kumar||2020-06-28 12:22:38||Re: [HACKERS] Custom compression methods|
|Previous Message||Daniel Gustafsson||2020-06-28 11:10:48||Commitfest 2020-07|