Re: Slight refactoring of state check in pg_upgrade check_ function

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Slight refactoring of state check in pg_upgrade check_ function
Date: 2022-08-31 13:10:47
Message-ID: B437679A-F700-4300-86EA-82DE42F595B7@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 30 Aug 2022, at 23:08, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Sun, Aug 28, 2022 at 03:06:09PM -0700, Nathan Bossart wrote:

>> The patch looks reasonable to me.
>
> +1. Those checks have accumulated over time with different authors,
> hence the stylistic differences.

Pushed, thanks for review!

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Imseih (AWS), Sami 2022-08-31 13:15:02 Re: [BUG] Panic due to incorrect missingContrecPtr after promotion
Previous Message Robert Haas 2022-08-31 12:56:31 allowing for control over SET ROLE