Skip site navigation (1) Skip section navigation (2)

Re: pg_dump --split patch

From: Robert Treat <rob(at)xzilla(dot)net>
To: Joel Jacobson <joel(at)gluefinance(dot)com>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump --split patch
Date: 2010-12-30 20:28:18
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Thu, Dec 30, 2010 at 2:13 AM, Joel Jacobson <joel(at)gluefinance(dot)com> wrote:

> 2010/12/29 Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
> Please have a look at getddl:
> Nice! Looks like a nifty tool.
> When I tried it, "./ -f -F /crypt/funcs -d glue", I got the error
> "No such file or directory: 'sql/schemas.sql'".
> While the task of splitting objects into separate files could be solved by
> an external "wrapper tool" like yours around pg_dump,
> I argue it makes more sense of putting the (minimal required) logics into
> pg_dump, due to a number of reasons, most importantly because it's simplier
> and less complex, thus less error prone.
> My patch is only a few lines of code and doesn't add any logics to pg_dump,
> it merely reroutes the fwrite() system calls based on the toc entries.
> Just the fact you and others had to create own tools to do the splitting
> shows the feature is important, which I think should be included in the
> normal pg_dump tool.

As someone whose own version of "getddl" helped inspire Dimitri to create
his own version, I've both enjoyed reading this thread and seeing this wheel
reinvented yet again, and wholeheartedly +1 the idea of building this
directly into pg_dump. (The only thing better would be to make everything
thing sql callable, but that's a problem for another day).

Robert Treat

In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2010-12-30 20:36:30
Subject: Re: Sync Rep Design
Previous:From: Aidan Van DykDate: 2010-12-30 20:24:09
Subject: Re: Sync Rep Design

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group