On Thu, Jul 8, 2010 at 17:11, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Thu, Jul 8, 2010 at 17:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> mha(at)postgresql(dot)org (Magnus Hagander) writes:
>>> Log Message:
>>> Add support for TCP keepalives on Windows, both for backend and the new
>>> libpq support.
>> Buildfarm member narwhal doesn't like this patch. You have about six
>> or eight hours to fix or revert it before beta3 wraps.
> Gah. Seems mingw is out of date with reality again. I'll go look for a
> vm with it on and see if I can find how to do it there.
> (and yes, I even asked Dave to do a special run with that bf member
> for me, and then forgot to check the result. sorry!)
Seems pretty simple - mingw doesn't have support for this. We have two
ways to deal with that I think:
1) Disable it on mingw.
2) Include it in our custom headers.
For #2, what we need to include is the define of SIO_KEEPALIVE_VALS as
well as the definition of struct tcp_keepalive.
We've done #2 before at least once, which worked well until mingw
suddenly caught up and added it a while later. It's not like this is a
new definition in windows, but we need to be ready for them to
eventually do that.
I guess there is:
3) write an autoconf test and provide them only when mingw doesn't have it.
if we're going with #3, I'll respectfully have to ask somebod yelse to
write the autoconf test, that's beyond me I think :-)
Opinions on which way to go?
In response to
pgsql-hackers by date
|Next:||From: Kevin Grittner||Date: 2010-07-08 15:36:58|
|Subject: Re: Reviewfest 2010-06 Plans and Call for Reviewers|
|Previous:||From: Magnus Hagander||Date: 2010-07-08 15:11:50|
|Subject: Re: pgsql: Add support for TCP keepalives on Windows, both for backend and|
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2010-07-08 15:39:14|
|Subject: Re: pgsql: Add support for TCP keepalives on Windows, both for backend and |
|Previous:||From: Tom Lane||Date: 2010-07-08 15:15:06|
|Subject: pgsql: Fix variant float8 expected files to have exactly the expected |