| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org> |
| Subject: | Re: wip: functions median and percentile |
| Date: | 2010-09-21 21:03:31 |
| Message-ID: | AANLkTimhSBJifs771o3ofEiOakN78jJn+ac4XY=0g_Q9@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-rrreviewers |
2010/9/21 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>> * Cosmetic coding style should be more appropriate, including trailing
>>> white spaces and indentation positions.
>>
>> can you specify where, please?
>
> I noticed a lot of problems in this area when working on your \ef /
> \sf patch, too. Trailing whitespace is nearly always bad, and it's
> not hard to find - just grep the diff for it. As for indentation, try
> to match the surrounding code.
is updated patch better?
Pavel
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise Postgres Company
>
| Attachment | Content-Type | Size |
|---|---|---|
| median.diff | text/x-patch | 12.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-09-21 21:09:09 | Is src/tools/add_cvs_markers still of any use? |
| Previous Message | Pei He | 2010-09-21 21:02:53 | Get the offset of a tuple inside a table |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hitoshi Harada | 2010-09-22 02:21:01 | Re: wip: functions median and percentile |
| Previous Message | Robert Haas | 2010-09-21 20:44:16 | Re: wip: functions median and percentile |