| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Josh Kupershmidt <schmiddy(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Tab completion for view triggers in psql |
| Date: | 2010-11-30 11:13:37 |
| Message-ID: | AANLkTimh=mfPoa8YG78UfCZdQ9JNDEKcaTbRis6vJrZ7@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 30, 2010 at 18:18, David Fetter <david(at)fetter(dot)org> wrote:
>> It expands all tables (and views) in tab-completion after INSERT,
>> UPDATE, and DELETE FROM. Is it an intended change?
I found it was a simple bug; we need ( ) around selcondition.
In addition, I modified your patch a bit:
* I added a separated CREATE TRIGGER INSTEAD OF if-branch
because it doesn't accept tables actually; it only accepts
views. OTOH, BEFORE or AFTER only accepts tables.
* I think "t.tgtype & (1 << N) <> 0" is more natural
bit operation than "t.tgtype | (1 << N) = t.tgtype".
Patch attached. If you think my changes are ok,
please change the patch status to "Ready for Committer".
--
Itagaki Takahiro
| Attachment | Content-Type | Size |
|---|---|---|
| psql_view_trigger_tab_completion_6.diff | application/octet-stream | 10.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2010-11-30 12:26:57 | Re: [GENERAL] column-level update privs + lock table |
| Previous Message | Heikki Linnakangas | 2010-11-30 10:02:50 | Re: GiST insert algorithm rewrite |