| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Change pg_last_xlog_receive_location not to move backwards |
| Date: | 2011-01-24 19:25:11 |
| Message-ID: | AANLkTimfyBOrbnHX4U6fPp34WP8GjyfogPfpQyk4MO=p@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 13, 2011 at 2:40 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Jan 13, 2011 at 4:24 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> So I'm thinking to change pg_last_xlog_receive_location not to
>> move backwards.
>
> The attached patch does that.
It looks to me like this is changing more than just the return value
of pg_last_xlog_receive_location. receivedUpto isn't only used for
that one function, and there's no explanation in your email or in the
patch of why the new behavior is correct and/or better for the other
places where it's used.
This email from Heikki seems to indicate that there's a reason for the
current behavior:
http://archives.postgresql.org/pgsql-hackers/2010-06/msg00586.php
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-01-24 19:29:31 | Re: READ ONLY fixes |
| Previous Message | Kevin Grittner | 2011-01-24 19:21:35 | Re: READ ONLY fixes |