Re: create tablespace fails silently, or succeeds improperly

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Dave Cramer <pg(at)fastcrypt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: create tablespace fails silently, or succeeds improperly
Date: 2010-10-18 19:03:08
Message-ID: AANLkTim6HZNyWDGSZn7ZjHVBRV8h-TbwtSp2V+6FhtOL@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 18, 2010 at 3:02 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> Robert Haas wrote:
>>> Perhaps we should fix the behavior rather than the documentation.
>
>> We can't fix the behavior because we have to allow an old cluster to
>> keep its tablespace files during a pg_upgrade.  They are given a script
>> to delete those files later, if they want.
>
> The new *layout* of the files may be forced by pg_upgrade
> considerations, but I don't think that proves much of anything about
> ownership and permissions settings --- especially not the fact that we
> are now enforcing settings that were designed for the data directory
> itself on what is effectively one level up from that.

I haven't yet been convinced we need or want to relax the rule about
the directory being empty.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-10-18 19:03:22 Re: create tablespace fails silently, or succeeds improperly
Previous Message Tom Lane 2010-10-18 19:02:15 Re: create tablespace fails silently, or succeeds improperly