Re: 64-bit pgbench V2

On Mon, Jul 5, 2010 at 8:17 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Greg Smith <greg(at)2ndquadrant(dot)com> writes:
>> The main tricky part was figuring how to convert the \setshell
>> implementation.  That uses strtol to parse the number that should have
>> been returned by the shell call.  It turns out there are a stack of ways
>> to do something similar but return 64 bits instead:
>
> Please choose a way that doesn't introduce new portability assumptions.
> The backend gets along fine without strtoll, and I don't see why pgbench
> should have to require it.

It doesn't seem very palatable to have multiple handwritten integer
parsers floating around the code base either. Maybe we should try to
standardize something and ship it in src/port, or somesuch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company