Skip site navigation (1) Skip section navigation (2)

Re: gincostestimate

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jan Urbański <wulczer(at)wulczer(dot)org>
Cc: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gincostestimate
Date: 2010-07-30 18:03:59
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Fri, Jul 30, 2010 at 1:19 PM, Jan Urbański <wulczer(at)wulczer(dot)org> wrote:
> The patch has lots of statements like if ( GinPageIsLeaf(page) ), that is
> with extra space between the outer parenthesis and the condition, which
> AFAIK is not the project style. I guess pgindent fixes that, so it's no big
> deal.

It's better if these get cleaned up.  pgindent will fix it eventually,
but the less stuff pgindent has to touch, the less likelihood there is
of breaking outstanding patches when it's run.

Robert Haas
The Enterprise Postgres Company

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-30 18:08:19
Subject: Re: reducing NUMERIC size for 9.1
Previous:From: Robert HaasDate: 2010-07-30 17:42:04
Subject: Re: reducing NUMERIC size for 9.1

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group