From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org, jaime(at)2ndquadrant(dot)com, david(at)fetter(dot)org |
Subject: | Re: How to reliably detect if it's a promoting standby |
Date: | 2010-10-20 14:51:40 |
Message-ID: | AANLkTikg50D6PgzLbwgDvgBx110inT66q47d8BgJ+cDR@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Oct 20, 2010 at 10:35 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 20.10.2010 17:32, Tatsuo Ishii wrote:
>>>>
>>>> pg_is_in_recovery() returns a bool, are you proposing to change that?
>>>
>>> No. I just thought about adding more condition when it returns true.
>>
>> Here is the patch. Comments are welcome!
>> ...
>> Datum
>> pg_is_in_recovery(PG_FUNCTION_ARGS)
>> {
>> ! /* use volatile pointer to prevent code rearrangement */
>> ! volatile WalRcvData *walrcv = WalRcv;
>> !
>> ! PG_RETURN_BOOL(RecoveryInProgress()&& walrcv->walRcvState ==
>> WALRCV_RUNNING);
>> }
>>
>
> This returns 'false' if you're in hot standby mode running against an
> archive. That seems wrong, I don't think the walreceiver state should play
> any role in this.
I think what we need is a second function, not a change to the
definition of this one.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2010-10-20 14:53:58 | Re: max_wal_senders must die |
Previous Message | Robert Haas | 2010-10-20 14:49:37 | Re: leaky views, yet again |