| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: wip: functions median and percentile |
| Date: | 2010-10-03 17:31:18 |
| Message-ID: | AANLkTikT-QExuaxW-6YMYHjM+UVkc9yNU2CrZfgHWOrX@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-rrreviewers |
Hello
2010/10/3 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> 2010/10/2 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>> Hello
>>
>> updated version
>> * memsort removed
>> * window aggregate support blocked
>
> I ran this patch and it looks good for committer.
> Just one thing, in src/backend/utils/adt/Makefile median.o to compile
> the new file is missing.
>
> And I'm now thinking about how to make median happen in window
> aggregate. In fact we might fix parse_func.c to distinguish the same
> name aggregate and window functions and median() can be implemented
> separately from aggregate one. But it's another story than this patch.
> For now we can commit the median aggregate only, without window
> function support.
>
> Regards,
>
Thank you very much for review
fixed patch + missing Makefile
Regards
Pavel Stehule
>
> --
> Hitoshi Harada
>
| Attachment | Content-Type | Size |
|---|---|---|
| median.diff | application/octet-stream | 17.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2010-10-03 20:37:43 | Re: pgadmin |
| Previous Message | Bernd Helmle | 2010-10-03 17:05:42 | ALTER DATABASE RENAME with HS/SR |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hitoshi Harada | 2010-10-04 06:36:48 | Re: wip: functions median and percentile |
| Previous Message | Greg Stark | 2010-10-03 15:49:37 | Re: wip: functions median and percentile |