Re: log_hostname and pg_stat_activity

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Steve Singer <ssinger_pg(at)sympatico(dot)ca>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: log_hostname and pg_stat_activity
Date: 2011-02-01 18:33:56
Message-ID: AANLkTikE2hFBTSwDxjm0DQ-3kAFzQh1i1WjjVO8_vr1H@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote:
>> However if I connect with a line in pg_hba that matches on an IP
>> network then my client_hostname is always null unless log_hostname is
>> set to true.  This is consistent with the behavior you describe but I
>> think the average user will find it a bit confusing.  Having a column
>> that is always null unless a GUC is set is less than ideal but I
>> understand why log_hostname isn't on by default.
>
> Well, we have all these track_* variables, which also control what
> appears in the statistics views.
>
> After thinking about this some more, I think it might be better to be
> less cute and forget about the interaction with the pg_hba.conf hostname
> behavior.  That is, the host name is set if and only if log_hostname is
> on.

+1 for doing it that way.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-02-01 18:35:13 Re: Spread checkpoint sync
Previous Message Robert Haas 2011-02-01 18:32:28 Re: Spread checkpoint sync