Skip site navigation (1) Skip section navigation (2)

Re: Source reindenting

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Source reindenting
Date: 2010-12-31 01:39:31
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
On Thu, Dec 30, 2010 at 10:02 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Not unless you add a VC++ build step to do it too...
> Ah, wasn't aware you actually committed from Windows. Thought you
> worked kind of like I do for the pg backend work which is do all
> windows stuff on a separate branch and then fold it into my local git
> repository and clean it up on linux before committing anything (which
> is where I clean up things like linebreaks and indention).

I keep my Windows and other repos entirely independent of one another.
Typically, I do commit new work from Windows though, as that's where I
mostly develop, and patches from OSX, as that's more convenient for
testing other people's work.

> There's an astyle package for windows. It's officially maintained.
> While I don't think it would be too easy to create a VS build step for
> it, it would probably be easy to create a .BAT file you could run
> prior to commit, if that would be enough? (Do you do your actual git
> work from inside VS as well? Daring!)

I don't use git from inside VC++ - but if you want astyle to be run
prior to every commit, then I'll want a batch file or something that's
easy to remember to call (note, if it's a batch file, it's easy to add
as a pre-build step - though it may be annoying if it changes

Or, we could just do it the PostgreSQL way - try to get it right
throughout the cycle, and then have a pgindent run prior to release to
be sure.

Dave Page
Twitter: @pgsnake

EnterpriseDB UK:
The Enterprise PostgreSQL Company

In response to


pgadmin-hackers by date

Next:From: Dave PageDate: 2010-12-31 09:26:22
Subject: Re: Email notification pgAgent
Previous:From: Dave PageDate: 2010-12-31 01:30:22
Subject: Re: Trac tickets

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group