Re: pgsql: Make the Windows tcp keepalive support depend on the existance of

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Make the Windows tcp keepalive support depend on the existance of
Date: 2010-07-08 16:45:06
Message-ID: AANLkTik--PhFlttqx4Z9Ks2PC9cVbtn1CRCTPzF3FJLV@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Jul 8, 2010 at 18:40, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> Magnus Hagander wrote:
>>
>> Log Message:
>> -----------
>> Make the Windows tcp keepalive support depend on the existance of the
>> SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't
>> support this API (yet?).
>>
>>
>>
>
> Maybe I misunderstood. I thought you were going to include the required
> defines if they were missing, rather than just disable the code in that
> case.

One of us definitely misunderstood, because this is how I read Tom's
suggestion. It'll be unsupported on mingw until they add the required
define and structure - and when they do, we'll automatically support
it.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-07-08 16:46:42 Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and
Previous Message Bruce Momjian 2010-07-08 16:44:12 pgsql: Doc change: effected -> affected, per correction from Matthew