From: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org> |
Subject: | Re: wip: functions median and percentile |
Date: | 2010-09-22 02:21:01 |
Message-ID: | AANLkTi=zC8tMPFcG+DYmF1shDtOC0kRyq1C2ycKqWC+h@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-rrreviewers |
2010/9/22 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
> 2010/9/21 Robert Haas <robertmhaas(at)gmail(dot)com>:
>> On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>>> * Cosmetic coding style should be more appropriate, including trailing
>>>> white spaces and indentation positions.
>>>
>>> can you specify where, please?
>>
>> I noticed a lot of problems in this area when working on your \ef /
>> \sf patch, too. Trailing whitespace is nearly always bad, and it's
>> not hard to find - just grep the diff for it. As for indentation, try
>> to match the surrounding code.
>
> is updated patch better?
Better, but you should be more careful, for example,
+ tuplesort_performsort(aggstate->sortstate);
+ <-- 1
+ while (tuplesort_getdatum(aggstate->sortstate,
+ true,
+ &value, &isNull))
For #1, please remove horizontal tabs in empty lines.
Regards,
--
Hitoshi Harada
From | Date | Subject | |
---|---|---|---|
Next Message | Abhijit Menon-Sen | 2010-09-22 02:32:57 | Re: repository size differences |
Previous Message | David E. Wheeler | 2010-09-22 02:16:31 | Re: Multi-branch committing in git, revisited |
From | Date | Subject | |
---|---|---|---|
Next Message | Hitoshi Harada | 2010-09-22 03:06:51 | Re: wip: functions median and percentile |
Previous Message | Pavel Stehule | 2010-09-21 21:03:31 | Re: wip: functions median and percentile |