Skip site navigation (1) Skip section navigation (2)

Re: wxWidgets 2.9 build

From: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgadmin-hackers(at)postgresql(dot)org, Dave Page <dpage(at)pgadmin(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: wxWidgets 2.9 build
Date: 2011-01-19 18:04:22
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
I decided to copy the OGL headers into /include/wx/ogl and proceed
with getting the remaining translation units to compile, where
compilation was completely aborted before due to ogl.h not being
available. I've posted to wx users, and to bakefile-devel, and will
hopefully have a solution to my linker problem soon. I've written my
own little wrapper function for Scintilla encoding functions that will
be temporarily used as a drop in replacement for wx2stc(). There is no
standard header that I can include for the Scintilla stuff (2
functions originally declared in UniConversion.h), so I've written
some extern declarations myself. I realise that this isn't acceptable
for production, but I think it's silly to worry about it until I can
actually run the code through a debugger  (i.e. the eventual
implementation that uses Wx utilities only).

Now, all object files compiled, except where we have Bison/Flex problems.

I have attached a patch for your information. Obviously, I am not
asking you to commit it. Most warnings have been fixed - I didn't fix
one in gqbGridPanel::OnButtonUp(wxCommandEvent&) where I think we
downcast with a C style cast.

I think I found a bug in pgRole.cpp at line 304, where we compared a
long to a wxString. Obviously wxString's newfound stronger typing
highlighted this. Comparing strings of OIDs instead ought to be safe,

Not quite sure how to proceed with bringing sqlGridBoolEditor (which
inherits from wxGridCellEditor) up to speed with 2.9, but that should
be clearer when I can debug. changes.txt says
"wxGridCellEditor::EndEdit() signature has changed and it was split in
two functions, one still called EndEdit() and ApplyEdit() (both are
pure, and ApplyEdit has no actual implementation). See the
documentation of the new functions for more details about how grid
editors should be written now". The docs say of AppyEdit()
"Effectively save the changes in the grid. This function should save
the value of the control in the grid. It is called only after
EndEdit() returns true."

Peter Geoghegan

Attachment: work_in_prog.patch
Description: text/x-patch (52.8 KB)

In response to


pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-01-19 20:19:41
Subject: Support for Slony 2.0?
Previous:From: Dave PageDate: 2011-01-19 13:55:25
Subject: Re: pgadmin crash on refresh

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group