Skip site navigation (1) Skip section navigation (2)

Re: Problem with insert - 1.12.0 RC1

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Erwin Brandstetter <brsaweda(at)gmail(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Problem with insert - 1.12.0 RC1
Date: 2010-09-02 11:59:59
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
On Thu, Sep 2, 2010 at 12:30 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 02/09/2010 10:28, Dave Page a écrit :
>> Anyway, can the code in the edit grid be modified to detect the empty
>> pgSet in place of null?
> Yeah, by checking how many rows were inserted. See patch attached. It
> fixes the issue. Not sure this is the way we should do it. I'm afraid
> there are other parts in the code where the "return new pgSet();" code
> will bite us.

Looks OK to me. I don't expect many other places will have issues - we
probably would have noticed by now.

Besides, fixing occurrences like this is probably much easier than
making reconnect work after an object has unexpectedly been handled a
null pgSet.

Dave Page
Twitter: @pgsnake

EnterpriseDB UK:
The Enterprise Postgres Company

In response to


pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-09-02 15:54:56
Subject: pgAdmin III commit: Check the number of rows inserted in frmEditGrid
Previous:From: Guillaume LelargeDate: 2010-09-02 11:30:24
Subject: Re: Problem with insert - 1.12.0 RC1

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group