On Fri, Mar 11, 2011 at 5:04 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> if ((wrote_xlog && XactSyncCommit) || forceSyncCommit || nrels > 0 ||
>> Whenever synchronous_replication is TRUE, we disable synchronous_commit.
>> But, before disabling that, we should check also max_wal_senders and
>> synchronous_standby_names? Otherwise, synchronous_commit can
>> be disabled unexpectedly even in non replication case.
> Yeah, that's bad. At the risk of repeating myself, I don't think this
> code should be checking SyncRepRequested() in the first place. If the
> user has turned off synchronous_commit, then we should just commit
> asynchronously, even if sync rep is otherwise in force. Otherwise,
> this if statement is going to get really complicated. The logic is
> already at least mildly wrong here anyway: clearly we do NOT need to
> commit synchronously if the transaction has not written xlog, even if
> sync rep is enabled.
Yeah, not to wait for replication when synchronous_commit is disabled
seems to be more reasonable.
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
In response to
pgsql-hackers by date
|Next:||From: Bruce Momjian||Date: 2011-03-11 11:02:26|
|Subject: Re: [BUGS] BUG #5842: Memory leak in PL/Python when taking
slices of results|
|Previous:||From: Bruce Momjian||Date: 2011-03-11 10:34:53|
|Subject: Re: Database file copy|
pgsql-committers by date
|Next:||From: Bruce Momjian||Date: 2011-03-11 10:55:43|
|Subject: pgsql: Document that libpq's PQgetResult() should be called after afat|
|Previous:||From: Bruce Momjian||Date: 2011-03-11 10:34:43|
|Subject: pgsql: Document that the parenthesized VACUUM syntax is deprecated,not|