Skip site navigation (1) Skip section navigation (2)

Re: patch for check constraints using multiple inheritance

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Yeb Havinga <yebhavinga(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Henk Enting <h(dot)d(dot)enting(at)mgrid(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch for check constraints using multiple inheritance
Date: 2010-07-31 16:02:23
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Fri, Jul 30, 2010 at 4:38 PM, Yeb Havinga <yebhavinga(at)gmail(dot)com> wrote:
>> I'm looking at ATPrepAddColumn right now, where there is actually some
>> comments about getting the right attinhcount in the case of multiple
>> inherited children, but it's the first time I'm looking at this part of
>> PostgreSQL and it needs some time to sink in. It looks a bit like at the
>> place of the comment /* child should see column as singly inherited */,
>> maybe the recursion could be stopped there as well, i.e. not only setting
>> inhcount to 1, but actually adding the child relation one time to the
>> wqueue.
> I believe the crux is to stop double recursion from a parent in
> ATOneLevelRecursion. I did a quick test by adding a globally defined
> static List *visitedrels = NIL;

I agree that's the crux of the problem, but I can't see solving it
with a global variable.  I realize you were just testing...

> PS: forgot to say thanks for looking into this problem earlier in the
> thread. Thanks!


Robert Haas
The Enterprise Postgres Company

In response to


pgsql-hackers by date

Next:From: Tom LaneDate: 2010-07-31 16:06:33
Subject: Re: ANALYZE versus expression indexes with nondefault opckeytype
Previous:From: Tom LaneDate: 2010-07-31 16:02:15
Subject: Re: rbtree code breaks GIN's adherence to maintenance_work_mem

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group