Skip site navigation (1) Skip section navigation (2)

Re: pg_dump --split patch

From: Joel Jacobson <joel(at)gluefinance(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: dmitry(at)koterov(dot)ru, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, David Wilson <david(dot)t(dot)wilson(at)gmail(dot)com>
Subject: Re: pg_dump --split patch
Date: 2011-01-03 18:33:39
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
2011/1/3 Robert Haas <robertmhaas(at)gmail(dot)com>:
> will become confusing for users and hard for us to maintain.  We're
> going to need to agree on something that won't be perfect for
> everyone, but will hopefully be a sufficient improvement for enough
> people to be worth doing.

Good point.
I think we can at least agree the "bare minimum" is splitting per
namespace, object type and name.

> On the specific issue of overloaded functions, I have a feeling that
> the only feasible option is going to be to put them all in the same
> file.  If you put them in different files, the names will either be
> very long (because they'll have to include the argument types) or
> fairly incomprehensible (if you did something like hash the argument
> types and append 8 hex digits to the function name) or not all that
> static (if you use OIDs; or if you number them sequentially, like
> foo1.sql, foo2.sql, foo3.sql, then foo3.sql might end up as foo2.sql
> on a system where there are only two variants of foo, making diff not
> work very well).

I agree.
Even if the overloaded functions are not written in the same order,
you will quickly and easily note "function(s) of this particular name
has been changed", which should narrow down your
mind-mapping-change-grasping-exercise quite a lot.

Best regards,

Joel Jacobson
Glue Finance

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-01-03 18:34:18
Subject: Re: pg_dump --split patch
Previous:From: Magnus HaganderDate: 2011-01-03 18:28:02
Subject: Re: back branches vs. VS 2008

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group