Re: Transaction timeout

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, 邱宇航 <iamqyh(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andrew Borodin <amborodin86(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers mailing list <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Transaction timeout
Date: 2024-02-22 17:23:24
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 19 Feb 2024, at 15:17, Japin Li <japinli(at)hotmail(dot)com> wrote:
> +1

PFA patch set of 4 patches:
1. remove all potential flaky tests. BTW recently we had a bingo when 3 of them failed together [0]
2-3. waiting injection points patchset by Michael Paquier, intact v2 from nearby thread.
4. prototype of simple TAP tests for timeouts.

I did not add a test for statement_timeout, because it still have good coverage in isolation tests. But added test for idle_sessoin_timeout.
Maybe these tests could be implemented with NOTICE injection points (not requiring steps 2-3), but I'm afraid that they might be flaky too: FATALed connection might not send information necesary for test success (we will see something like "PQconsumeInput failed: server closed the connection unexpectedly" as in [1]).

Best regards, Andrey Borodin.


Attachment Content-Type Size
0001-Remove-flacky-isolation-tests-for-timeouts.patch application/octet-stream 6.2 KB
0004-Add-timeouts-TAP-tests.patch application/octet-stream 6.5 KB
0003-Add-regression-test-for-restart-points-during-promot.patch application/octet-stream 9.2 KB
0002-injection_points-Add-routines-to-wait-and-wake-proce.patch application/octet-stream 7.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dima Rybakov (Tlt) 2024-02-22 18:22:03 how to read table options during smgropen()
Previous Message Heikki Linnakangas 2024-02-22 17:02:51 Re: Experiments with Postgres and SSL