Re: Add SKIP LOCKED to VACUUM and ANALYZE

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Andres Freund" <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Lyes Ameddah <lyes(dot)amd(at)gmail(dot)com>
Subject: Re: Add SKIP LOCKED to VACUUM and ANALYZE
Date: 2018-09-05 15:24:21
Message-ID: A41D618D-E5BD-403D-B128-69D63AE69349@amazon.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 9/4/18, 1:32 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
>On Tue, Sep 04, 2018 at 03:49:09PM +0000, Bossart, Nathan wrote:
>> Yes. I've started working on this again, but the new patch set is
>> probably still a few days out.
>
> Thanks, Nathan.

And here it is. Here is a summary of the notable changes:

1) Patches v8-0003 and v8-0008 have been discarded. These patches
added SKIP_LOCKED behavior when opening a relation's indexes.
Instead, I've documented that VACUUM and ANALYZE may still block
on indexes in v9-0007.
2) Patches v8-0004 and v8-0005 have been discarded, as they have
already been committed.
3) Patch v8-0011 has been discarded. As previously noted, VACUUM
(SKIP_LOCKED, FULL) is already handled in vacuum_rel(), so no
changed are required to cluster_rel(). However, we will need
something similar to v8-0011 if we ever add SKIP_LOCKED to
CLUSTER.
4) The option has been renamed to SKIP_LOCKED (with the underscore)
for consistency with the DISABLE_PAGE_SKIPPING option.
5) In the documentation, I've listed the caveats for SKIP_LOCKED and
partitioned tables. I tried to make all the new documentation as
concise as possible.

Nathan

Attachment Content-Type Size
v9-0007-Open-up-VACOPT_SKIP_LOCKED-to-users.patch application/octet-stream 14.4 KB
v9-0006-Skip-VACUUM-ANALYZE-with-VACOPT_SKIP_LOCKED-if-ex.patch application/octet-stream 1.6 KB
v9-0005-Skip-ANALYZE-with-VACOPT_SKIP_LOCKED-if-acquire_i.patch application/octet-stream 5.4 KB
v9-0004-Create-a-helper-function-for-cleaning-up-from-do_.patch application/octet-stream 2.1 KB
v9-0003-Add-skip_locked-argument-to-find_all_inheritors.patch application/octet-stream 11.6 KB
v9-0002-Add-skip_locked-argument-to-find_inheritance_chil.patch application/octet-stream 8.6 KB
v9-0001-Create-a-helper-function-for-determining-the-log-.patch application/octet-stream 4.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-09-05 15:27:16 Re: Funny hang on PostgreSQL 10 during parallel index scan on slave
Previous Message Chris Travers 2018-09-05 15:22:36 Funny hang on PostgreSQL 10 during parallel index scan on slave