Re: Reducing connection overhead in pg_upgrade compat check phase

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Reducing connection overhead in pg_upgrade compat check phase
Date: 2024-02-09 09:33:37
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 9 Feb 2024, at 00:04, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 8 Feb 2024, at 15:16, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> One option could perhaps be to include a version number for <= comparison, and
>> if set to zero a function pointer to a version check function must be provided?
>> That would handle the simple cases in a single place without messy logic, and
>> leave the more convoluted checks with a special case function.
> The attached is a draft version of this approach, each check can define to run
> for all versions, set a threshold version for which it runs or define a
> callback which implements a more complicated check.

And again pgindented and with documentation on the struct members to make it
easy to add new checks. A repetitive part of the report text was also moved to
a single place.

Daniel Gustafsson

Attachment Content-Type Size
v14-0001-pg_upgrade-run-all-data-type-checks-per-connecti.patch application/octet-stream 42.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Maiquel Grassi 2024-02-09 09:38:35 RE: Psql meta-command conninfo+
Previous Message Maiquel Grassi 2024-02-09 09:18:44 RE: Psql meta-command conninfo+