Re: Refactor ssl tests to avoid using internal PostgreSQL::Test::Cluster methods

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactor ssl tests to avoid using internal PostgreSQL::Test::Cluster methods
Date: 2023-09-22 11:52:26
Message-ID: A23DA57B-CB09-4928-97A5-3B3C9F9F39FF@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 3 Jul 2023, at 13:37, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:

> If "pg_ctl restart" fails because of a timeout, for example, the PID file could be present. Previously, the _update_pid(0) would error out on that, but now it's accepted. I think that's fine, but just wanted to point it out.

Revisiting an old patch. Agreed, I think that's fine, so I went ahead and
pushed this. Thanks for review!

It's unfortunately not that common for buildfarm animals to run the SSL tests,
so I guess I'll keep an extra eye on the CFBot for this one.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2023-09-22 12:20:56 RE: pg_ctl start may return 0 even if the postmaster has been already started on Windows
Previous Message shveta malik 2023-09-22 11:48:56 Re: Synchronizing slots from primary to standby