Skip site navigation (1) Skip section navigation (2)

Proposed dirmod.c fix for Win32

From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: "'pgsql-hackers-win32(at)postgresql(dot)org'" <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Proposed dirmod.c fix for Win32
Date: 2004-01-29 09:11:20
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F2AD@harris.memetrics.local (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-hackers-win32
The current version of dirmod.c causes a compilation failure under MingW:

../../../src/port/libpgport.a(dirmod.o.b)(.text+0xe1): In function
e:/cygwin/opt/diff8c/pgsql/src/port/dirmod.c:38: undefined reference to
gsql/src/port/dirmod.c:38: undefined reference to `elog_finish'

and so on.

[dirmod.c provides replacements for unlink + rename under Win32. These
functions are currently only ever used by the backend code, and by

One solution is, obviously, to drop the elog calls...

A somewhat better solution is to move dirmod.c into
src/backend/port(/win32?), and just compile dirmod.c directly into the
backend. pg_resetxlog could then use dirmod.c just as it currently uses
pg_crc.c (refer to Makefile in pg_resetxlog directory). One additional
requirement would be for pg_resetxlog to be considered a FRONTEND component.

Does anyone take issue with this (and/or is it advisable to add -DFRONTEND
to pg_resetxlog Makefile; seems ok to me), or have a better idea, before I
go create/submit a patch?


Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 

pgsql-hackers by date

Next:From: lndDate: 2004-01-29 09:17:11
Subject: Re: Question about indexes
Previous:From: Karel ZakDate: 2004-01-29 08:01:33
Subject: Re: msg translation into sk_SK, Docs: SGML -> XML

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2004-01-30 15:58:44
Subject: Fix for win32 sleep
Previous:From: Claudio NatoliDate: 2004-01-28 22:48:06
Subject: Re: [PATCHES] win32 patch: allows source to be compiled + "run" u

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group