From: | Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | "'pgsql-hackers-win32(at)postgresql(dot)org'" <pgsql-hackers-win32(at)postgresql(dot)org> |
Subject: | Proposed dirmod.c fix for Win32 |
Date: | 2004-01-29 09:11:20 |
Message-ID: | A02DEC4D1073D611BAE8525405FCCE2B55F2AD@harris.memetrics.local |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-hackers-win32 |
The current version of dirmod.c causes a compilation failure under MingW:
../../../src/port/libpgport.a(dirmod.o.b)(.text+0xe1): In function
`pgrename':
e:/cygwin/opt/diff8c/pgsql/src/port/dirmod.c:38: undefined reference to
`errstart'
../../../src/port/libpgport.a(dirmod.o.b)(.text+0xef):e:/cygwin/opt/diff8c/p
gsql/src/port/dirmod.c:38: undefined reference to `elog_finish'
and so on.
[dirmod.c provides replacements for unlink + rename under Win32. These
functions are currently only ever used by the backend code, and by
pg_resetxlog]
One solution is, obviously, to drop the elog calls...
A somewhat better solution is to move dirmod.c into
src/backend/port(/win32?), and just compile dirmod.c directly into the
backend. pg_resetxlog could then use dirmod.c just as it currently uses
pg_crc.c (refer to Makefile in pg_resetxlog directory). One additional
requirement would be for pg_resetxlog to be considered a FRONTEND component.
Does anyone take issue with this (and/or is it advisable to add -DFRONTEND
to pg_resetxlog Makefile; seems ok to me), or have a better idea, before I
go create/submit a patch?
Cheers,
Claudio
---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>
From | Date | Subject | |
---|---|---|---|
Next Message | lnd | 2004-01-29 09:17:11 | Re: Question about indexes |
Previous Message | Karel Zak | 2004-01-29 08:01:33 | Re: msg translation into sk_SK, Docs: SGML -> XML |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-01-30 15:58:44 | Fix for win32 sleep |
Previous Message | Claudio Natoli | 2004-01-28 22:48:06 | Re: [PATCHES] win32 patch: allows source to be compiled + "run" u |