Nope. My bad. My head has an off by one error.
Drop the first part of the patch, but the second part could be retained.
Off to hide in shame,
> -----Original Message-----
> From: Claudio Natoli [mailto:claudio(dot)natoli(at)memetrics(dot)com]
> Sent: Wednesday, 26 November 2003 12:34 PM
> To: pgsql-patches(at)postgresql(dot)org
> Subject: [PATCHES] Bug in fd.c (FreeFile)
> I believe FreeFile has an "off by one" type error. Apart from possibly
> accessing past the end of the array, when combined with the
> while loop call
> from CleanupTempFiles, it contrives to fail to fclose a
> number of files [at
> a guess, floor((numAllocatedFiles-1)/2)] when
> CleanupTempFiles is called
> (unless I'm completely mistaken).
> Change 1: Begin search from "correct" [logical] final element of array
> Change 2: Minor speed-up to CleanupTempFiles (knowing that
> FreeFile iterates
> from the [logical]
> final element of the array)
> Apply to HEAD (bug also exists in 7.4 branch, possibly others...)
> Certain disclaimers and policies apply to all email sent from
> For the full text of these disclaimers and policies see
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
pgsql-patches by date
|Next:||From: Robert Treat||Date: 2003-11-26 03:00:43|
|Subject: Re: minor cleanup in plpgsql.sgml|
|Previous:||From: Claudio Natoli||Date: 2003-11-26 01:34:09|
|Subject: Bug in fd.c (FreeFile)|